jason/xmpp-email-bridge
Watch
1
0
Fork
You've already forked xmpp-email-bridge
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Code review: fix critical login bug, install script improvements, docs accuracy #3

Merged
jason merged 6 commits from jason/code-review-fixes into main 2026-07-06 13:06:03 -04:00
Conversation 0 Commits 6 Files changed 6 +92 -59
jason commented 2026-07-06 03:16:09 -04:00
Owner
Copy link

Code review identified and fixed 5 issues across the codebase:

Critical

  • xmpp-email-bridge.py:254: Fixed server.login(bridge_jid.user, password) → server.login(credentials['jid'], password). The .user attribute access caused AttributeError because credentials['jid'] is a string, not an slixmpp JID object. This blocked XMPP→Email forwarding.

Medium

  • Added --config-path CLI flag to install.sh:32 (parallel to existing --domain). Fixed AGENTS.md install docs from broken sudo env var syntax (sudo DOMAIN=x ...) to proper CLI flags.
  • Fixed uninstall in install.sh:192-202: previously wiped ALL transport_maps with postconf -e "transport_maps =". Now filters out only the bridge entry, preserving other configured transports.

Low

  • README.md:204-207: Clarified Reply-To description to "sender's Cheogram JID" (code always sets Reply-To to from_jid at line 265).
  • README.md:101: Changed "ending in cheogram.com" to "matching cheogram.com" for Postfix domain matching precision.
Code review identified and fixed 5 issues across the codebase: **Critical** - `xmpp-email-bridge.py:254`: Fixed `server.login(bridge_jid.user, password)` → `server.login(credentials['jid'], password)`. The `.user` attribute access caused `AttributeError` because credentials['jid'] is a string, not an slixmpp JID object. This blocked XMPP→Email forwarding. **Medium** - Added `--config-path` CLI flag to `install.sh:32` (parallel to existing `--domain`). Fixed AGENTS.md install docs from broken sudo env var syntax (`sudo DOMAIN=x ...`) to proper CLI flags. - Fixed uninstall in `install.sh:192-202`: previously wiped ALL transport_maps with `postconf -e "transport_maps ="`. Now filters out only the bridge entry, preserving other configured transports. **Low** - `README.md:204-207`: Clarified Reply-To description to "sender's Cheogram JID" (code always sets Reply-To to from_jid at line 265). - `README.md:101`: Changed "ending in cheogram.com" to "matching cheogram.com" for Postfix domain matching precision.
jason merged commit 1674172ed1 into main 2026-07-06 13:06:03 -04:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
jason/xmpp-email-bridge!3
No description provided.